Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap mp backend and update interaction parameters easily #128

Merged
merged 19 commits into from
Apr 30, 2023

Conversation

cbouy
Copy link
Member

@cbouy cbouy commented Apr 29, 2023

@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Merging #128 (add8bea) into master (433a400) will increase coverage by 0.44%.
The diff coverage is 93.99%.

❗ Current head add8bea differs from pull request most recent head b233f60. Consider uploading reports for the commit b233f60 to get more accurate results

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   95.96%   96.40%   +0.44%     
==========================================
  Files          11       14       +3     
  Lines        1066     1114      +48     
==========================================
+ Hits         1023     1074      +51     
+ Misses         43       40       -3     
Impacted Files Coverage Δ
prolif/interactions/utils.py 73.33% <73.33%> (ø)
prolif/parallel.py 78.31% <77.77%> (+25.12%) ⬆️
prolif/fingerprint.py 96.50% <97.77%> (+1.47%) ⬆️
prolif/interactions/base.py 98.83% <98.83%> (ø)
prolif/__init__.py 100.00% <100.00%> (ø)
prolif/ifp.py 100.00% <100.00%> (ø)
prolif/interactions/__init__.py 100.00% <100.00%> (ø)
prolif/interactions/interactions.py 100.00% <100.00%> (ø)
prolif/molecule.py 99.33% <100.00%> (ø)
prolif/plotting/network.py 96.20% <100.00%> (ø)
... and 2 more

self.prot_pattern = MolFromSmarts(prot_pattern)
self.distance = distance

def detect(self, lig_res, prot_res):

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
self._measure_distance = DISTANCE_FUNCTIONS[distance_atom]
self._metadata_mapping = metadata_mapping

def detect(self, lig_res, prot_res):

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
self._measure_distance = DISTANCE_FUNCTIONS[distance_atoms]
self._metadata_mapping = metadata_mapping

def detect(self, lig_res, prot_res):

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
self.intersect = intersect
self.intersect_radius = intersect_radius

def detect(self, ligand, residue):

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
self.distance = distance
self.angle = tuple(radians(i) for i in angle)

def detect(self, cation, pi):

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
self._vdw_cache = {}
self.vdwradii = {**VDWRADII, **vdwradii} if vdwradii else VDWRADII

def detect(self, ligand, residue):

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
@cbouy cbouy changed the title Update interaction parameters easily Swap mp backend and update interaction parameters easily Apr 30, 2023
@cbouy cbouy merged commit 7c1c284 into master Apr 30, 2023
@cbouy cbouy deleted the update-parameters branch April 30, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment