-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Repro: go to todomvc, check an item, type something that'd filter it out, see that for the brief unmounting animation the check mark is gone (stale `isDone: false`). This fixes that by removing the dirty check in `clearUnreadPropStyle`. We now setState every time this is called (every willUpdate). This is not underperformant as willUpdate will batch that setState without triggering an extra render. There are a bunch of nuances in this. I knew the staleness was a problem but kept the dirty check anyway because fwiw `rehydrateStyles` always picked the freshest `data` (the field in `TransitionStyle`), and the dirty data is never read anywhere. Apparently I was wrong. This piece is tricky and should be revisited/commented better. (No test yet.)
- Loading branch information
Showing
2 changed files
with
39 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters