bugfix: multiple shadow threads rendered at the same time, small prob… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ability crash. Background: on the Tab Page, every tab has a React Page. If the React page is not using the same ReactInstanceManager, multiple shadow threads will be generated. A crash can occur when multiple pages are rendered at the same time. Reasons of issue: PropSetter class VIEW_MGR_ARGS, VIEW_MGR_GROUP_ARGS, SHADOW_ARGS, SHADOW_GROUP_ARGS is static. one shadow put data in static array, it was changed by another shadow thread before method invoke. The solution: use ThreadLocal instead of static array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ability crash.
Background:
on the Tab Page, every tab has a React Page. If the React page is not using the same ReactInstanceManager, multiple shadow threads will be generated.
A crash can occur when multiple pages are rendered at the same time.
Reasons of issue: PropSetter class VIEW_MGR_ARGS, VIEW_MGR_GROUP_ARGS, SHADOW_ARGS, SHADOW_GROUP_ARGS is static.
one shadow put data in static array, it was changed by another shadow thread before method invoke.
The solution:
use ThreadLocal instead of static array.
Summary
Changelog
[CATEGORY] [TYPE] - Message
Test Plan