Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate maven_jar rule #23

Merged
merged 3 commits into from
Nov 24, 2019
Merged

Deprecate maven_jar rule #23

merged 3 commits into from
Nov 24, 2019

Conversation

chenrui333
Copy link
Owner

@chenrui333 chenrui333 commented Nov 24, 2019

Fixes #21
Relates to bazelbuild/bazel#6799

@chenrui333 chenrui333 changed the title Update syntax Deprecate maven_jar rule Nov 24, 2019
@chenrui333 chenrui333 marked this pull request as ready for review November 24, 2019 03:34
@chenrui333 chenrui333 requested a review from softprops November 24, 2019 03:34
Copy link
Contributor

@softprops softprops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for picking this up @chenrui333

@chenrui333
Copy link
Owner Author

np!

@chenrui333 chenrui333 merged commit 0c65ba9 into master Nov 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the update-syntax branch November 24, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please upgrade code to newer Bazel versions?
2 participants