Replacement for template strings does not work

[leifmarcus]

When bundling the application for production with the terser minifier, the __dynamic_base__ is not overridden, when it appears inside a template string like /__dynamic_base__/${e}. (After the compression, the preload helper will have a code like that for saving deps, that are already loaded).

This is related to the replaceQuotes function inside the plugin utils.

vite-plugin-dynamic-base/src/core/utils.ts

Line 8 in 90b1969

export function replaceQuotes(mark: string, placeholder: string, code: string) {

A suggested change would be:

function replaceQuotes(mark, placeholder, code) {
    const singleMark = `'${mark}`;
    const singlePlaceholder = `${placeholder}+'/`;
    const doubleMark = `"${mark}`;
    const doublePlaceholder = `${placeholder}+"/`;
    const templateMark = `\`${mark}`;
    const templatePlaceholder = `\`\$\{${placeholder}\}/`;
    return replace(doubleMark, doublePlaceholder, replace(singleMark, singlePlaceholder, replace(templateMark, templatePlaceholder, code)));
}

[chenxch]

@leifmarcus Thanks for your feedback, the fix version 0.4.3 has been released.

[modten]

Still encounter this problem with 1.0.0.
The ast function doesn't seem to handle TemplateLiteral.

[joarfish]

@modten Yes, you might be right. Can you open a new issue with some example code and your build target?

[modten]

@joarfish Sorry, I think there is no need to delve into this problem, because after I use the latest versions of vite and terser, this problem no longer exists.

The steps that caused the original problem were to use vite@2.9.16 and @vitejs/plugin-vue@2.3.4, then use defineAsyncComponent to load the component asynchronously, and finally use terser for compression at build time. Then you can get the code where the problem occurred:

e=`/__dynamic_base__/${e}`

const HelloWorld = defineAsyncComponent(() => import(`./components/HelloWorld.vue`))

{
   build: {
     minify: "terser"
   }
}

[joarfish]

@modten Thanks for the info. Glad that it works for you with the upgraded versions 👍

@chenxch I can still have a look at template literals next week because I think they are not taken into account.