feat: Allow DID fragment de-referencing [DEV-1172] #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to dev-1172-dereferencing � Conflicts: � main.go
Improve logging and configuration
askolesov
previously approved these changes
May 13, 2022
|
Great work! |
ankurdotb
requested changes
May 13, 2022
There was a problem hiding this comment.
@Toktar There are a few minor changes here but I'm also don't expect you to fix this before you go on holiday. Will pick it up with Alex K while you're out.
I'm also going to set this to a draft PR and block merging until we resolve DEV-1322 since we have zero Go linting and quality checks at the moment on this repo. Will plan that out with Alex.
|
Implemented this task in scope of the PR: |
ankurdotb
requested changes
May 19, 2022
Signed-off-by: Andrew Nikitin <andrew.nikitin@cheqd.io>
Signed-off-by: Andrew Nikitin <andrew.nikitin@cheqd.io>
ankurdotb
approved these changes
May 19, 2022
ankurdotb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.