Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support v2 protos [DEV-1912] #67

Merged
merged 42 commits into from
Jan 30, 2023
Merged

feat: Support v2 protos [DEV-1912] #67

merged 42 commits into from
Jan 30, 2023

Conversation

DaevMithran
Copy link
Contributor

No description provided.

askolesov
askolesov reviewed Nov 22, 2022
View reviewed changes
Copy link
Contributor

@askolesov askolesov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

types/did_doc.go Outdated Show resolved Hide resolved
types/did_doc_metadata_test.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@DaevMithran
Copy link
Contributor Author

@askolesov can you check why the golang linter is failing, looks like some dependency issue. Thanks

@rosspower11 rosspower11 changed the title feat: Support v2 protos feat: Support v2 protos [DEV-1912] Nov 22, 2022
@ankurdotb
Copy link
Contributor

Task linked: DEV-1912 Update existing did-resolver to use latest version of cheqd-node / latest protobuf definitions

@DaevMithran DaevMithran force-pushed the integrateV2Protos branch 3 times, most recently from b4e358b to 95fb8f6 Compare November 23, 2022 12:29
@DaevMithran DaevMithran temporarily deployed to staging November 30, 2022 05:50 Inactive
@ankurdotb ankurdotb temporarily deployed to staging December 2, 2022 11:36 Inactive
@ankurdotb ankurdotb temporarily deployed to staging December 2, 2022 11:42 Inactive
@DaevMithran DaevMithran temporarily deployed to staging December 5, 2022 13:02 Inactive
ankurdotb
ankurdotb requested changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@ankurdotb ankurdotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See ClickUp for changes requested/to consider

@DaevMithran DaevMithran temporarily deployed to staging December 6, 2022 10:11 Inactive
@DaevMithran DaevMithran temporarily deployed to staging December 7, 2022 05:34 — with GitHub Actions Inactive
@DaevMithran DaevMithran temporarily deployed to staging December 7, 2022 06:34 — with GitHub Actions Inactive
@DaevMithran DaevMithran temporarily deployed to staging January 27, 2023 12:16 — with GitHub Actions Inactive
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging January 28, 2023 13:55 — with GitHub Actions Inactive
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging January 28, 2023 18:54 — with GitHub Actions Inactive
@Tweeddalex
Copy link
Contributor

@DaevMithran is there anything blocking this being merged?

@abdulla-ashurov
Copy link
Contributor

@DaevMithran is there anything blocking this being merged?

I implemented all the API except get AllDidDocVersionsMetadata

@abdulla-ashurov abdulla-ashurov temporarily deployed to staging January 30, 2023 06:20 — with GitHub Actions Inactive
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging January 30, 2023 06:42 — with GitHub Actions Inactive
@abdulla-ashurov
Copy link
Contributor

@DaevMithran is there anything blocking this being merged?

Done! ✅

@abdulla-ashurov abdulla-ashurov temporarily deployed to staging January 30, 2023 06:49 — with GitHub Actions Inactive
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging January 30, 2023 07:17 — with GitHub Actions Inactive
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging January 30, 2023 07:42 — with GitHub Actions Inactive
@DaevMithran DaevMithran merged commit 885c8b7 into develop Jan 30, 2023
@DaevMithran DaevMithran deleted the integrateV2Protos branch January 30, 2023 07:57
@abdulla-ashurov abdulla-ashurov restored the integrateV2Protos branch January 30, 2023 08:31
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging January 30, 2023 08:35 — with GitHub Actions Inactive
DaevMithran added a commit that referenced this pull request Jan 30, 2023
@DaevMithran @ankurdotb @abdulla-ashurov
feat!: Support v2 protos [DEV-1912] (#67)
2ee30bd 
* feat: Support v2 protos

* fix: Remove local dependency

* fix: Test cases

* feat: Remove fixCheckSum helper

* build: Upgrade cheqd-node

* Update to latest cheqd-node package

* Update Dockerfile

* fix: Resolution metadata unittest

* feat: Support version query && fix Unit tests

* feat: Parse verification material in result

* feat: Support Migrated DIDs

* feat: Add query in swagger && fix unit test

* build: Upgrade cheqd-node

* fix: Modify publicKeyJWK type

* go mod tidy

* go mod tidy

* feat: Upgrade latest cheqd-node

* feat: Update verificationMethod resolution

* build: Upgrade latest cheqd-node

* fix: Error comparison

* Fix problem with integration tests

* Refactor unit tests

* Update RESOURCE_DATA variable

* Commit Mainnet DIDs in integration tests

* test: Add migrated DID tests

* feat: Add verificationKey contexts

* fix: Uint tests

* Add API for getting DIDDoc specific version

* Add integration test for testing API for getting specific DID version

* Add negative integration test for testing API getting specific DID version

* Add API for getting all DIDDoc versions

* Refactor code

* Add integration tests for testing get all DID versions API

* Change API for getting metadata for all resources in collection

* Remove not need integration tests

* We should use already implemented migrations functions instead of create own

---------

Co-authored-by: Ankur Banerjee <ankurdotb@users.noreply.github.com>
Co-authored-by: abdulla-ashurov <abdulla.ashurov@dsr-corporation.com>
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging January 31, 2023 06:01 — with GitHub Actions Inactive
@ankurdotb ankurdotb deleted the integrateV2Protos branch February 15, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askolesov askolesov Awaiting requested review from askolesov

@ankurdotb ankurdotb Awaiting requested review from ankurdotb

@lampkin-diet lampkin-diet Awaiting requested review from lampkin-diet

Assignees

@DaevMithran DaevMithran

@abdulla-ashurov abdulla-ashurov

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DaevMithran @ankurdotb @Tweeddalex @abdulla-ashurov @askolesov