test: Add credential API tests [DEV-3238] #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaevMithran
force-pushed
the
credential-test
branch
from
78139f8
to
7408291
Compare
DaevMithran
force-pushed
the
credential-test
branch
from
3ac252d
to
554a8b3
Compare
DaevMithran
force-pushed
the
credential-test
branch
from
99c890d
to
1697197
Compare
DaevMithran
changed the title
|
Task linked: DEV-3238 Add tests to the /credential/issue API |
DaevMithran
force-pushed
the
credential-test
branch
from
62529bc
to
336f5f8
Compare
DaevMithran
force-pushed
the
credential-test
branch
7 times, most recently
from
8b195e8
to
57fc185
Compare
DaevMithran
force-pushed
the
credential-test
branch
7 times, most recently
from
c160998
to
bda140d
Compare
DaevMithran
force-pushed
the
credential-test
branch
from
bda140d
to
81a14f8
Compare
DaevMithran
force-pushed
the
credential-test
branch
2 times, most recently
from
7b0a81e
to
e842826
Compare
DaevMithran
force-pushed
the
credential-test
branch
from
e842826
to
b2ccba7
Compare
DaevMithran
force-pushed
the
credential-test
branch
2 times, most recently
from
c769b8c
to
a1a9cfb
Compare
DaevMithran
force-pushed
the
credential-test
branch
from
a1a9cfb
to
a7c47eb
Compare
lampkin-diet
suggested changes
Dec 18, 2023
There was a problem hiding this comment.
Hey! Thanks for your work. I think it worse to make some extra checks.
- For issued credentials let's check the info that can be verified at this point, like:
- issuer is as expected,
- credentialSubject is the same
- credentialStatus field is placed and has expected type
- type includes
VerifiableCredentialtype
- Also, Maybe it worse to double check that all the changes are made for credential statusList objects also. Let's check also, that revocation/suspension/reinstantion also reflect to statusList changes.
ankurdotb
changed the title
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
lampkin-diet
approved these changes
Dec 22, 2023
|
🎉 This PR is included in version 2.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
lampkin-diet
pushed a commit
that referenced
this pull request
Dec 26, 2023
* feat: Add jsonld tests * Debug * use did list * Use existing did in json * assert responses * Update format in payload * Minor fix * Add assertionMethod * Add verify credential tests * Add revocation tests * Run tests with one worker * fix minor issue * Match complete responses * Update package-lock.json * MAke the same style for tests --------- Co-authored-by: Ankur Banerjee <ankurdotb@users.noreply.github.com> Co-authored-by: Andrew Nikitin <andrew.nikitin@cheqd.io>
lampkin-diet
pushed a commit
that referenced
this pull request
Dec 26, 2023
* feat: Add jsonld tests * Debug * use did list * Use existing did in json * assert responses * Update format in payload * Minor fix * Add assertionMethod * Add verify credential tests * Add revocation tests * Run tests with one worker * fix minor issue * Match complete responses * Update package-lock.json * MAke the same style for tests --------- Co-authored-by: Ankur Banerjee <ankurdotb@users.noreply.github.com> Co-authored-by: Andrew Nikitin <andrew.nikitin@cheqd.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.