Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create base button #144

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Create base button #144

merged 4 commits into from
Sep 18, 2023

Conversation

willybrauner
Copy link
Member

No description provided.

@willybrauner willybrauner requested review from theoplawinski and removed request for Bastou September 12, 2023 08:30
@willybrauner
Copy link
Member Author

@theoplawinski aria-label still missing, can you add it as props?

@willybrauner willybrauner merged commit d0157c2 into main Sep 18, 2023
1 check passed
@willybrauner willybrauner deleted the base-button branch November 2, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theoplawinski theoplawinski Awaiting requested review from theoplawinski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willybrauner @theoplawinski