Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get sub router base get sub router routes #122

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

willybrauner
Copy link
Member

@willybrauner willybrauner commented Oct 18, 2022

  • Fix getSubRouterBase & getSubRouterRoutes in case LangService.showDefaultLangInUrl is set to false.
  • Update documentation
  • Update tests
  const path = getPathByRouteName(router.routes, "FooPage");
  // (if last param is false, '/:lang' will be not added) -> "/base/:lang/foo"
  const subBase = getSubRouterBase(path, router.base, true);
  // get subRoutes
  const subRoutes = getSubRouterRoutes(path, router.routes);

@willybrauner willybrauner changed the base branch from main to v3 October 18, 2022 17:42
@willybrauner willybrauner merged commit af9f08c into v3 Oct 18, 2022
@willybrauner willybrauner deleted the fix-getSubRouterBase-getSubRouterRoutes branch October 18, 2022 18:16
@willybrauner willybrauner mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant