Codechef atcoder support #470

iampjeetsingh · 2021-07-22T06:00:24Z

Implemented the following ;handle identify, ;handle set, ;handle list, ;ranklist commands for CodeChef / AtCoder / Google (Kickstart)

cheran-senthil · 2021-07-22T14:07:34Z

~~Don't think we want these for other sites, general consensus is against this.~~

krofna · 2021-07-22T14:28:15Z

#94 for reference

iampjeetsingh · 2021-07-22T15:16:43Z

Which features were you talking in #468 then?

krofna · 2021-07-22T15:24:29Z

@iampjeetsingh just ignore what cheran said. this requires detailed discussion. please provide your discord username so that we can invite you to the development server

iampjeetsingh · 2021-07-22T15:34:24Z

My discord username is thesupremeone#1162

algmyr · 2021-07-23T16:57:12Z

README.md

@@ -84,6 +85,7 @@ Fill in appropriate variables in new "environment" file.
 - **ALLOW_DUEL_SELF_REGISTER**: boolean value indicating if self registration for duels is enabled.
 - **TLE_ADMIN**: the name of the role that can run admin commands of the bot. If this is not set, the role name will default to "Admin".
 - **TLE_MODERATOR**: the name of the role that can run moderator commands of the bot. If this is not set, the role name will default to "Moderator".
+- **CLIST_API_TOKEN**: Credential for accessing clist api, You can find your api key [here][https://clist.by/api/v2/doc/] after creating an account on clist.by. If this is not set, codechef/atcoder/google(kickstart) related commands won't work.


Markdown links are [label](url), with parentheses.

algmyr · 2021-08-22T11:08:00Z

tle/cogs/contests.py

        """Shows ranklist for the contest with given contest id. If handles contains
        '+server', all server members are included. No handles defaults to '+server'.
+
+        You can frame contest_id as follow


"You can specify contest_id as follows"?

algmyr · 2021-08-22T11:11:39Z

tle/cogs/contests.py

+        Use QR for Qualification Round and WF for World Finals.
+
+        # If nothing works
+        Use clist contest_id. You have to prefix - sign to clist contest-id otherwise it will be considered a codeforces contest id.


Could we consider doing this with a clist prefix rather than a minus sign? The minus way seems like a hack to me.

algmyr · 2021-08-22T11:15:13Z

tle/cogs/contests.py

-    async def _show_ranklist(self, channel, contest_id: int, handles: [str], ranklist, vc: bool = False, delete_after: float = None):
-        contest = cf_common.cache2.contest_cache.get_contest(contest_id)
+    async def _show_ranklist(self, channel, contest_id: int, handles, ranklist, vc: bool = False, delete_after: float = None, contest=None):
+        contest = contest or cf_common.cache2.contest_cache.get_contest(contest_id)


Not a big issue, but it would be neat if we could get away with only having 1 arg, rather than both contest and contest_id. Though I'm not sure what a clean option would be here.

algmyr · 2021-08-22T11:22:17Z

tle/cogs/handles.py

@@ -13,13 +13,17 @@
 from gi.repository import Pango, PangoCairo

 import discord
-import random
+import random, string


Small nit on style, prefer doing one import per line and keep imports sorted. I think the codebase is a bit inconsistent on that atm, but it's good to try to fix such issues as we go/don't make it messier.

algmyr · 2021-08-22T12:52:18Z

tle/util/clist_common.py

+    if is_int(contest_id):
+        contest_id = int(contest_id)
+        if contest_id<0:
+            contest_id = -1*contest_id


As mentioned elsewhere, not dealing with negative ints would be nicer.

algmyr · 2021-08-22T13:07:47Z

tle/util/clist_common.py

+        indexes[i] = letters[i]
+    standings = clist.format_standings(statistics, index_map, indexes)
+    ranklist = CRanklist(contest, standings, deltas=deltas if rated else None, problems_indexes=indexes)
+    return ranklist


A lot of these functions are on the form

if cf: minor logic + dispatch to cf_common do complex clist logic

It might make sense to have a some overarching util (maybe resource_util for lack of better words) that does the backend agnostic work+the minor logic in the pseudocode above, and dispatches to cf_util or clist_util for specific implementations of e.g. ranklist. I.e. that ranklist functions does minor logic followed by dispatch to the specific impl of ranklist.

I suppose the resource code should also move there, just leaving the clist impl details here.

algmyr · 2021-08-22T13:09:38Z

tle/util/db/user_db_conn.py

@@ -5,6 +5,7 @@
 from discord.ext import commands


@meooow25 or @narutse, could you look at the db related code?

algmyr · 2021-08-22T13:19:18Z

tle/util/scaper.py

@@ -0,0 +1,25 @@
+from bs4 import BeautifulSoup
+import requests


Might want to make this use aiohttp like the rest of the code which makes the request async.

algmyr · 2021-08-22T13:21:15Z

tle/util/scaper.py

@@ -0,0 +1,25 @@
+from bs4 import BeautifulSoup


File comment:
If the core clist identify logic gets moved to clist_common this scraper code could be moved there.

narutse · 2021-08-22T22:05:14Z

tle/util/clist_api.py

+        offset+=1000
+    return results
+
+class Contest(CfContest):


I think having Contest subclass CfContest to change one field is a bit weird. Should probably put this in a common class.

iampjeetsingh added 9 commits July 22, 2021 09:36

Created tables necessary for storing clist users

44b5dd9

Implemented clist api call and scraper for handle linking

8d725ad

Finished ;handle identify/set for CodeChef/AtCoder/Google(Kickstart)

4347ac1

Implemented ranklist for CodeChef/AtCoder/Google(Kickstart)

1619113

Minor fixes

8d3b159

Implemented handle list for clist resources

8d78601

Updated readme (Provided information about clist environment variable)

29e1c28

Created task for refreshing clist user cache every 2 hour

efdccb7

Added clist error messages to discord_common

4cb734c

cheran-senthil closed this Jul 22, 2021

algmyr reopened this Jul 22, 2021

cheran-senthil requested a review from algmyr July 22, 2021 14:24

iampjeetsingh added 2 commits August 1, 2021 19:55

Restructured clist code to clist_common

90ad47d

minor bug fix

d3e37da

krofna requested review from meooow25 and krofna August 8, 2021 21:06

algmyr requested changes Aug 22, 2021

View reviewed changes

narutse reviewed Aug 22, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Codechef atcoder support #470

Codechef atcoder support #470

iampjeetsingh commented Jul 22, 2021

cheran-senthil commented Jul 22, 2021 •

edited

Loading

krofna commented Jul 22, 2021

iampjeetsingh commented Jul 22, 2021

krofna commented Jul 22, 2021

iampjeetsingh commented Jul 22, 2021

algmyr Jul 23, 2021

algmyr Aug 22, 2021

algmyr Aug 22, 2021

algmyr Aug 22, 2021 •

edited

Loading

algmyr Aug 22, 2021

algmyr Aug 22, 2021

algmyr Aug 22, 2021

algmyr Aug 22, 2021

algmyr Aug 22, 2021

algmyr Aug 22, 2021

narutse Aug 22, 2021

		@@ -0,0 +1,25 @@
		from bs4 import BeautifulSoup
		import requests

Codechef atcoder support #470

Are you sure you want to change the base?

Codechef atcoder support #470

Conversation

iampjeetsingh commented Jul 22, 2021

cheran-senthil commented Jul 22, 2021 • edited Loading

krofna commented Jul 22, 2021

iampjeetsingh commented Jul 22, 2021

krofna commented Jul 22, 2021

iampjeetsingh commented Jul 22, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

algmyr Aug 22, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cheran-senthil commented Jul 22, 2021 •

edited

Loading

algmyr Aug 22, 2021 •

edited

Loading