Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java upgrade #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Java upgrade #33

wants to merge 2 commits into from

Conversation

xrl
Copy link

@xrl xrl commented Jan 17, 2017

The NetflixOSS image is at least a year old

image

I've borrowed bits from https://github.com/dockerfile/java/tree/master/oracle-java8 and we're doing the java8 install ourselves. We could just ineherit from them but I don't think they publish to the docker registry.

@xrl xrl mentioned this pull request Jan 18, 2017
@ches
Copy link
Owner

ches commented Mar 31, 2017

Hi @xrl, thanks for working on this, and my apologies for being unresponsive for a long while. Among other things I've been drinking from the firehose at a new $DAYJOB. On the plus side I'm starting to use this container in a work capacity, so hopefully I'll be more attentive to it.

I'm going to merge Kafka version updates and tag image builds for the stable release versions. About the base image change, I'm thinking of switching to an Alpine-based Java image to reduce the image size, so I'll explore this before making the change you've proposed here. Thoughts?

@xrl
Copy link
Author

xrl commented Mar 31, 2017

Any change off of the 1+ year old JVM image would be a win. Keep in mind that the repo I use in mine is actively maintained and it drags in the Oracle JVM which is has a reputation for being better optimized than the OpenJDK alternative. But I do like a nice alpine container. In any case, sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants