Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for disabling unclean leader election #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YarekTyshchenko
Copy link

@YarekTyshchenko YarekTyshchenko commented Feb 19, 2018

Its disabled by default here, in effort to be idiomatic, as it will be
disabled in newer versions of kafka by default too. (from 0.11.0.0)

Let me know what you think, and if you need help backporting it to older tags (I'm interested in the v0.10.0.1 tag myself)

Btw, this is a fantastic repository. A while ago I tried to achieve a similar thing: getting kafka to run on a single docker host. You've kept this updated, and in pristine condition. 👍 good work!

Its disabled by default here, in effort to be idiomatic, as it will be
disabled in newer versions of kafka by default too. (from `0.11.0.0`)
@YarekTyshchenko
Copy link
Author

Also, you should look into using Sigil (https://github.com/gliderlabs/sigil) for server config templating. Its much nicer than going through sed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant