Remove outdated mcrypt dependency and rely on native node crypto #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 2, 2021 10:27
MCRYPT_RIJNDAEL_128 seems to be alias name for AES-256-CBC
crypto's createCipheriv / createDecipheriv handle the padding for you
Closed
|
Hwy @b00tsy you should publish a JsCryptor-3 on npm :) |
kevkevinpal
reviewed
Feb 9, 2023
Comment on lines
+29
to
+31
| "dependencies": { | ||
| "mcrypt": "^0.1" | ||
| } |
|
|
||
| var _settings = {}; | ||
|
|
||
| var _configure_settings = function(version) { | ||
| var settings = { | ||
| algorithm: 'rijndael-128', | ||
| algorithm: 'aes-256-cbc', |
There was a problem hiding this comment.
are rijndael-128 and aes-256-cbc compatible would these break implementations that need backward compatibility?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mcrypt is not maintained anymore node versions >= 12 can't use JSCryptor anymore.
Relying solely on node crypto might break backwards compatibility (not sure which versions will work).
TODO:
find out which node versions support native node crypto and if there are versions left behind decide whether they can be ditched