Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup umul() #195

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Cleanup umul() #195

merged 1 commit into from
Mar 4, 2021

Conversation

gumb0
Copy link
Collaborator

@gumb0 gumb0 commented Mar 1, 2021

Pulled out of #180 with a test fixed in a boring way.

@codecov-io
Copy link

codecov-io commented Mar 1, 2021

Codecov Report

Merging #195 (8d4d5c0) into master (9a5d0ca) will decrease coverage by 0.89%.
The diff coverage is 86.20%.

@@             Coverage Diff             @@
##            master     #195      +/-   ##
===========================================
- Coverage   100.00%   99.10%   -0.90%     
===========================================
  Files            9        9              
  Lines         2332     2335       +3     
===========================================
- Hits          2332     2314      -18     
- Misses           0       21      +21     

@gumb0 gumb0 force-pushed the cleanup-umul branch 3 times, most recently from 18eda72 to 8d4d5c0 Compare March 1, 2021 18:48
@gumb0
Copy link
Collaborator Author

gumb0 commented Mar 1, 2021

@chfast Not sure what to do with coverage here, any ideas?

#if defined(__SIZEOF_INT128__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wpedantic"
if (!is_constant_evaluated())
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using builtin uint128 is fine in constexpr too. The is_constant_evaluated() is only actually needed for MSVC usage of intrinsic. We can keep it if not too big problem.

@chfast
Copy link
Owner

chfast commented Mar 1, 2021

@chfast Not sure what to do with coverage here, any ideas?

Yes, the 32-bit will not have __int128. We just need 32-bit build + collect coverage from it.

@chfast
Copy link
Owner

chfast commented Mar 1, 2021

We just need 32-bit build + collect coverage from it.

This has landed, you can rebase now.

@chfast chfast force-pushed the cleanup-umul branch 4 times, most recently from e1658b3 to d297c13 Compare March 4, 2021 08:20
Co-authored-by: Andrei Maiboroda <andrei@ethereum.org>
Copy link
Collaborator Author

@gumb0 gumb0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@chfast chfast merged commit 6c39eb7 into master Mar 4, 2021
@chfast chfast deleted the cleanup-umul branch March 4, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants