cmake: Require C++20 #287
Merged
cmake: Require C++20 #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
cxx20
branch
5 times, most recently
from
9c6c5ba to
8f0a528
Compare
axic
reviewed
Mar 22, 2023
include/intx/intx.hpp
Outdated
| #elif defined(_MSC_VER) | ||
| __assume(false); | ||
| #endif | ||
| } |
There was a problem hiding this comment.
What happens in the else case? Do we use this mostly for optimisations or also expect it as a safeguard?
There was a problem hiding this comment.
Mostly for optimization but sometimes helps with compiler warnings. Undefined Behavior Sanitizer has it instrumented.
|
@chfast what is the blocker on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.