Avoid producing invalid iterators in division loops #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #309 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 10 10
Lines 1886 1890 +4
=======================================
+ Hits 1885 1889 +4
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
No performance difference observed. |
chfast
force-pushed
the
refactor_div_loops
branch
from
51f866d to
3886b49
Compare
gumb0
approved these changes
Aug 6, 2024
This decouples loop end expression from the iterator decrement. Previously, the `it--` produced invalid iterator to `u[-1]` in the last iteration. It might have not been a big deal for execution because the loop terminated and the iterator was unused, but this was theoretical undefined behavior and constexpr context didn't like it either.
chfast
force-pushed
the
refactor_div_loops
branch
from
3886b49 to
5510a01
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decouples loop end expression from the iterator decrement. Previously, the
it--produced invalid iterator tou[-1]in the last iteration. It might have not been a big deal for execution because the loop terminated and the iterator was unused, but this was theoretical undefined behavior and constexpr context didn't like it either.