Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSVC build in preprocessor conformance mode #327

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

chfast
Copy link
Owner

@chfast chfast commented Oct 9, 2024

We need to split "" and _u tokens in the DEFINE_ALIAS_AND_LITERAL macro to make it conformant with the C11 preprocessor.

We need to split `""` and `_u` tokens in the `DEFINE_ALIAS_AND_LITERAL`
macro to make it conformant with the C11 preprocessor.
Copy link

sonarqubecloud bot commented Oct 9, 2024

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (72ae825) to head (beddb23).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #327   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          10       10           
  Lines        1811     1829   +18     
=======================================
+ Hits         1810     1828   +18     
  Misses          1        1           
Flag Coverage Δ
32bit 99.94% <ø> (ø)
gcc 99.39% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/intx/intx.hpp 99.85% <ø> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

@chfast chfast merged commit 8885521 into master Oct 9, 2024
19 checks passed
@chfast chfast deleted the msvc_conformance_fix branch October 9, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant