Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interceptor): check config in responseError #132

Closed
wants to merge 1 commit into from

Conversation

PatrickJS
Copy link
Contributor

sometimes there are http rejects without config objects from other interceptors

sometimes there are http rejects without config objects from other interceptors
@lord2800
Copy link

lord2800 commented Nov 3, 2014

Those other interceptors are the problem--config should always be an object. See #50.

@PatrickJS
Copy link
Contributor Author

if that's the throwing an error with that explanation would be a lot more beneficial and prevent the same PR from happening

@chieffancypants
Copy link
Owner

Thanks for the help @lord2800!

This certainly does seem to come up quite a lot, but I've never been fond of the idea of adding code here to detect problems in other projects. Throwing an error would be perfect if the error wasn't intermittent, but as it is, it could cause more issues than simply ignoring the problem in the first place.

Perhaps $logging the error would help bring awareness to poorly implemented interceptors, while allowing the app to remain operational?

@PatrickJS
Copy link
Contributor Author

Here is a PR for the log so others can fix their repo #133

@PatrickJS PatrickJS closed this Nov 4, 2014
@PatrickJS PatrickJS deleted the patch-1 branch November 4, 2014 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants