-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👷 Launch runs for regression tests from CI (1/2) #1
Merged
sgiavasis
merged 94 commits into
childmindresearch:main
from
shnizzedy:regression/after_runs
Oct 10, 2023
Merged
👷 Launch runs for regression tests from CI (1/2) #1
sgiavasis
merged 94 commits into
childmindresearch:main
from
shnizzedy:regression/after_runs
Oct 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# This is the 1st commit message: :construction_worker: Set check status # The commit message childmindresearch#2 will be skipped: # fixup! 👷 Set check status # The commit message childmindresearch#3 will be skipped: # fixup! fixup! 👷 Set check status
8 tasks
YAY. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to
Related to FCP-INDI/C-PAC#1904 by @amygutierrez
Part of a series toward automating regression testing
WORKDIR
to final-stage Dockerfiles FCP-INDI/C-PAC#1999 + 👷 Launch runs for regression tests from CI (2/2) FCP-INDI/C-PAC#2001Description
This PR updates the logic of these SLURM scripts to facilitate automated launches on an HPC from GitHub Actions. A more detailed explanation can be found in the updated README.
Technical details
This is just part of the solution to ✨ Automate Regression Testing FCP-INDI/C-PAC#1904. With these changes, we
Subsequent PRs to FCP-INDI/C-PAC + cmi-dair/slurm_testing + FCP-INDI/regtest-runlogs + amygutierrez/regression_dashboard will automate correlating the new run to a previous run (for the regression test) and reporting back those results
Tests
I've been running all these changes on bridges-2 via CI on my forks of these repos to test.
Screenshots
When runs fail, the checks should show red like https://github.com/FCP-INDI/C-PAC/assets/5974438/c2613976-a1d7-4237-a8c1-2015fe1d674c
In any case, logs should be available on GitHub like this.
Checklist
Update index.md
).main
branch of the repository.Developer Certificate of Origin
Developer Certificate of Origin