Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Launch runs for regression tests from CI (1/2) #1

Merged
merged 94 commits into from
Oct 10, 2023

Conversation

shnizzedy
Copy link
Contributor

Related to

Related to FCP-INDI/C-PAC#1904 by @amygutierrez

Part of a series toward automating regression testing

  1. this PR
  2. 📦️ Restore WORKDIR to final-stage Dockerfiles FCP-INDI/C-PAC#1999 + 👷 Launch runs for regression tests from CI (2/2) FCP-INDI/C-PAC#2001

Description

This PR updates the logic of these SLURM scripts to facilitate automated launches on an HPC from GitHub Actions. A more detailed explanation can be found in the updated README.

Technical details

Tests

I've been running all these changes on bridges-2 via CI on my forks of these repos to test.

Screenshots

When runs fail, the checks should show red like https://github.com/FCP-INDI/C-PAC/assets/5974438/c2613976-a1d7-4237-a8c1-2015fe1d674c

In any case, logs should be available on GitHub like this.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the main branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

shnizzedy added 30 commits July 20, 2023 13:08
# This is the 1st commit message:

:construction_worker: Set check status

# The commit message childmindresearch#2 will be skipped:

# fixup! 👷 Set check status

# The commit message childmindresearch#3 will be skipped:

# fixup! fixup! 👷 Set check status
@sgiavasis
Copy link
Contributor

YAY.

@sgiavasis sgiavasis merged commit 3e719f9 into childmindresearch:main Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants