Make connectivity check more robust #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some endpoints chosen for connectivity check may return an error, for example, due to rate limits being exceeded. However, as long as the given website could be reached, it means the connection's working and fallback to NAT Gateway should not be initiated. Such occurrences can be simply logged but treated as check success. Add a `User-Agent` header to connection check requests, which also prevents some websites from returning an error in the first place.
bwhaley
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
LGTM 👍
Out of curiosity, what URLs are you hitting that are returning rate limit errors? I wouldn't think that alternat alone would bump in to any rate limits, esp with URLs like www.google.com or www.example.com.
|
We were using GitHub API as one of the check URLs, where the rate limit is 60 requests per hour without authentication. An endpoint hosted by CloudFlare, in turn, returned Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some endpoints chosen for connectivity check may return an error, for example, due to rate limits being exceeded. However, as long as the given website could be reached, it means the connection's working and fallback to NAT Gateway should not be initiated. Such occurrences can be simply logged but treated as check success.
Add a
User-Agentheader to connection check requests, which also prevents some websites from returning an error in the first place.