Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path can be empty string #110

Merged
merged 2 commits into from
Sep 20, 2016
Merged

path can be empty string #110

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3cdd94
path can be empty string
sunnylqm Sep 11, 2016
f597c1d
Update index.js
sunnylqm Sep 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ function HttpProxyMiddleware(context, opts) {
if (pathRewriter) {
var path = pathRewriter(req.url, req);

if (path) {
if (path !== false) {
Copy link
Owner

@chimurai chimurai Sep 12, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the condition to:

if (typeof path === 'string') {
   ...
}

req.url = path;
} else {
logger.info('[HPM] pathRewrite: No rewritten path found. (%s)', req.url);
Expand Down