bug(websocket): memory leak when option 'ws:true' is used. #114

chimurai · 2016-09-26T20:29:03Z

fixes #113

coveralls · 2016-09-26T20:32:32Z

Coverage increased (+0.04%) to 96.914% when pulling e4f8da7 on ws-memory-leak into 4db1bfa on master.

julbra

@chimurai This fixes the leak in my tests. Thank you!

chimurai · 2016-09-28T22:35:17Z

Fix is shipped in v0.17.2

Thanks for reporting the issue. Appreciate all the effort @julbra !

julbra · 2016-09-30T09:07:17Z

Excellent, glad to be of help!

bug(websocket): fix memory leak when option 'ws:true' is used.

e4f8da7

chimurai referenced this pull request Sep 26, 2016

fix(websocket): fixes websocket upgrade issue (#82)

53fe79b

chimurai changed the title ~~bug(websocket): fix memory leak when option 'ws:true' is used.~~ bug(websocket): memory leak when option 'ws:true' is used. Sep 26, 2016

julbra approved these changes Sep 27, 2016

View reviewed changes

chimurai merged commit 2bf1f93 into master Sep 28, 2016

chimurai deleted the ws-memory-leak branch September 28, 2016 22:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bug(websocket): memory leak when option 'ws:true' is used. #114

bug(websocket): memory leak when option 'ws:true' is used. #114

chimurai commented Sep 26, 2016

coveralls commented Sep 26, 2016 •

edited

Loading

julbra left a comment

chimurai commented Sep 28, 2016

julbra commented Sep 30, 2016

bug(websocket): memory leak when option 'ws:true' is used. #114

bug(websocket): memory leak when option 'ws:true' is used. #114

Conversation

chimurai commented Sep 26, 2016

coveralls commented Sep 26, 2016 • edited Loading

julbra left a comment

Choose a reason for hiding this comment

chimurai commented Sep 28, 2016

julbra commented Sep 30, 2016

coveralls commented Sep 26, 2016 •

edited

Loading