refactor: replace lodash with small libraries #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`camelcase` and `is-plain-obj` are small, single purpose and dependency free utilities with builtin TS support.
|
That's funny, just created almost the same branch; 9 minutes prior to your PR :D |
chimurai
reviewed
Mar 27, 2021
| } else if ( | ||
| rewriteConfig === undefined || | ||
| rewriteConfig === null || | ||
| _.isEqual(rewriteConfig, {}) |
There was a problem hiding this comment.
_.isEqual(rewriteConfig, {}) check is now missing in the refactored code. Think the vanilla version would be: JSON.stringify(rewriteConfig) === '{}'.
There was a problem hiding this comment.
Comparing to empty object means it should be plain one, right? There is plain object check above. I moved Object.keys length check to return value instead. So isEqual check is redundant.
There was a problem hiding this comment.
Ah, you're right. Missed that part. 👌
|
I would stick to Sindre's version. In my experience it's more popular than is-plain-object (which I maintain). |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
camelcaseandis-plain-objare small, single purpose anddependency free utilities with builtin TS support. They cover all
left lodash usages.