Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript): type improvements #882

Merged
merged 7 commits into from
Mar 3, 2023
Merged

feat(typescript): type improvements #882

merged 7 commits into from
Mar 3, 2023

Conversation

chimurai
Copy link
Owner

@chimurai chimurai commented Feb 22, 2023

Description

Improve TypeScript typings.

  • Removed @types/express peerDependency
  • Contextual Typing support for express-like servers

Motivation and Context

How has this been tested?

  • tests
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@coveralls
Copy link

coveralls commented Feb 22, 2023

Coverage Status

Coverage: 97.872%. Remained the same when pulling 6c7d2c4 on type-improvements into fd4e558 on master.

@chimurai chimurai changed the title feat: typescript type improvements [BREAKING CHANGE] feat: typescript type improvements Feb 22, 2023
@chimurai chimurai changed the title feat: typescript type improvements feat(typescript): type improvements Feb 22, 2023
@chimurai chimurai merged commit 0ef0be6 into master Mar 3, 2023
@chimurai chimurai deleted the type-improvements branch March 3, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment