Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test forms #107

Merged
merged 16 commits into from
Mar 3, 2024
Merged

Test forms #107

merged 16 commits into from
Mar 3, 2024

Conversation

siasktv
Copy link
Contributor

@siasktv siasktv commented Feb 23, 2024

Description

Created e2e tests for forms routes.

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • [ X] Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

yarn test:e2e forms

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@cherylli
Copy link
Contributor

Hi @siasktv is this ready for review? If not, please make it a draft.

@cherylli cherylli marked this pull request as draft February 23, 2024 13:35
JoshuaHinman
JoshuaHinman previously approved these changes Feb 24, 2024
Copy link
Contributor

@JoshuaHinman JoshuaHinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed

@siasktv siasktv marked this pull request as ready for review February 26, 2024 13:14
@cherylli
Copy link
Contributor

@siasktv could you please update the change log. Please make sure everything is checked in the checklist (if applicable)

JoshuaHinman
JoshuaHinman previously approved these changes Feb 27, 2024
Copy link
Contributor

@JoshuaHinman JoshuaHinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok - All tests passed

Piero7210
Piero7210 previously approved these changes Feb 27, 2024
@siasktv siasktv dismissed stale reviews from Piero7210 and JoshuaHinman via af0937a February 27, 2024 02:40
@siasktv
Copy link
Contributor Author

siasktv commented Feb 27, 2024

@siasktv could you please update the change log. Please make sure everything is checked in the checklist (if applicable)

Thx! Change log has been updated as well

CHANGELOG.md Show resolved Hide resolved
test/forms.e2e-spec.ts Outdated Show resolved Hide resolved
test/forms.e2e-spec.ts Outdated Show resolved Hide resolved
test/forms.e2e-spec.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! All tests passed locally

Copy link
Contributor

@JoshuaHinman JoshuaHinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed

@siasktv siasktv merged commit 36a724a into dev Mar 3, 2024
1 check passed
@siasktv siasktv deleted the test-forms branch March 3, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants