Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Meeting Ids to sprints/teams endpoint #119

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Conversation

cherylli
Copy link
Contributor

Description

[frontend change request] Add Meeting Ids to sprints/teams endpoint so we can link the meeting Id to the sprint

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

checked responses on swagger, ran all the tests

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@cherylli cherylli self-assigned this Mar 17, 2024
Copy link
Contributor

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problems within the changed files. But in the sprints.e2e-spec.ts test file, I getting the following error saying "error TS2307: Cannot find module 'jest-extended".
Can you provide what changes you made or update the test to not use jest-extended package?

@cherylli
Copy link
Contributor Author

I don't see any problems within the changed files. But in the sprints.e2e-spec.ts test file, I getting the following error saying "error TS2307: Cannot find module 'jest-extended". Can you provide what changes you made or update the test to not use jest-extended package?

I think this has been resolved on discord - fyi and other encountering this issue, it was because an additional package was installed in the sprints e2e test PR. When using the docker setup you'll have to do yarn install inside the container

timDeHof
timDeHof previously approved these changes Mar 19, 2024
Copy link
Contributor

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every tests works now.

siasktv
siasktv previously approved these changes Mar 19, 2024
@cherylli cherylli dismissed stale reviews from siasktv and timDeHof via 45517a4 March 19, 2024 20:11
@cherylli cherylli merged commit fca3549 into dev Mar 19, 2024
1 check passed
@cherylli cherylli deleted the chore/sprints-add-meetingid branch March 19, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants