Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update sprints #139

Merged
merged 9 commits into from
Apr 26, 2024
Merged

Chore/update sprints #139

merged 9 commits into from
Apr 26, 2024

Conversation

curtwl
Copy link
Contributor

@curtwl curtwl commented Apr 22, 2024

Description

Minor changes:

  • Updated /voyages/sprints by removing teamMeetings from the response of getSprintDatesByTeamId.
  • Added VoyageResponseWithoutMeetings and SprintWithoutMeetings to the API response definitions.

Issue link

Fixes https://app.clickup.com/t/86azu18qn

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

JoshuaHinman
JoshuaHinman previously approved these changes Apr 23, 2024
Copy link
Contributor

@JoshuaHinman JoshuaHinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good - all tests passed!

Copy link
Contributor

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you changed the wrong endpoint. It looks like you changed voyages/sprints/teams/{teamId} instead of voyages/sprints as per the task description.

Copy link
Contributor

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It works as expected now. I like that you included the clickup link in the Issues section, maybe we should all start doing that

@cherylli cherylli requested a review from JoshuaHinman April 24, 2024 01:23
Copy link
Contributor

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! All unit and e2e tests pass. running swagger and GET /voyages/sprints produced a response that doesn't have the teamMeetings.

@curtwl curtwl merged commit 43a3bfe into dev Apr 26, 2024
1 check passed
@curtwl curtwl deleted the chore/update-sprints branch April 26, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants