-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/sprints add voyage dates #147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything works fine but I found out that the endpoint 200 sample response doesn't match the actual response, maybe we can update it in another PR
I noticed that too - I could follow up with another revision |
Co-authored-by: Cheryl M <webmaster@cherylli.com>
sure if you don't mind, I've also added another task for that on clickup so if you decide to do it you can claim that and add to this, otherwise happy to just merge this first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes looks good . It passes all the unit and e2e tests
I've updated the response to match the example, and fixed a test that broke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. I think you changed the actually response instead of the sample response, but this works too, I think they won't need solo project date but the other 2 dates could be useful in future
That's funny - yeah I assumed it should go the other way, but whatever you think is fine |
Description
Updates response for route
GET /api/v1/voyages/sprints/teams/{teamId}
- adds startDate and endDate to voyage properties-also added soloProjectDeadline, certificateIssueDate, showcasePublishDate to response body
Issue link
Fixes task 86b026m0d
Type of change
How Has This Been Tested?
yarn test:e2e sprints
Tested in swagger
Checklist: