Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update yarn test command #148

Merged
merged 1 commit into from
May 10, 2024
Merged

update yarn test command #148

merged 1 commit into from
May 10, 2024

Conversation

cherylli
Copy link
Contributor

@cherylli cherylli commented May 8, 2024

Description

changed yarn test (and the docker equivalent) to yarn test:unit and repurpose yarn test (and yarn test:docker) to run both unit and e2e test and suppress all console.log. We can also add integration tests and coverage later on

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

tested on docker and non docker setup

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@cherylli cherylli self-assigned this May 8, 2024
Copy link
Contributor

@Ajen07 Ajen07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the updated scripts are working fine in docker and non-docker environment

Copy link
Contributor

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job! Run all commands for unit, e2e, and combine one and they all worked. I like how descriptive the commands are now.

@cherylli cherylli merged commit c110ca7 into dev May 10, 2024
1 check passed
@cherylli cherylli deleted the update-test-command branch May 10, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants