Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: no check on voyage team member #159

Merged
merged 5 commits into from
Jun 7, 2024
Merged

Conversation

Ajen07
Copy link
Contributor

@Ajen07 Ajen07 commented Jun 2, 2024

Description

  • Added custom validation pipe for voyage team member id in the request body
  • It restricts the check-in submission from arbitrary member ids
  • Added e2e test for api/v1/voyages/sprints/check-in

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

It passes all the existing and new tests. It is tested with swagger for desired output

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@Ajen07 Ajen07 added the bug label Jun 2, 2024
@Ajen07 Ajen07 self-assigned this Jun 2, 2024
Copy link
Contributor

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected and all tests passed! 🚀

Copy link
Contributor

@JoshuaHinman JoshuaHinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All test passed, response worked on swagger - excellent job!

@Ajen07 Ajen07 merged commit 9e4ad27 into dev Jun 7, 2024
1 check passed
@Ajen07 Ajen07 deleted the bug/no-check-on-voyageTeamMemberId branch June 7, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants