Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/e2e tests for users #165

Merged
merged 14 commits into from
Jun 16, 2024
Merged

Test/e2e tests for users #165

merged 14 commits into from
Jun 16, 2024

Conversation

Ajen07
Copy link
Contributor

@Ajen07 Ajen07 commented Jun 14, 2024

Description

  • e2e tests for api/v1/users

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested with yarn test:docker

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@Ajen07 Ajen07 self-assigned this Jun 14, 2024
JoshuaHinman
JoshuaHinman previously approved these changes Jun 15, 2024
Copy link
Contributor

@JoshuaHinman JoshuaHinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed

src/teams/teams.controller.ts Outdated Show resolved Hide resolved
src/teams/teams.controller.ts Outdated Show resolved Hide resolved
test/users.e2e-spec.ts Outdated Show resolved Hide resolved
test/users.e2e-spec.ts Outdated Show resolved Hide resolved
@Ajen07 Ajen07 requested a review from cherylli June 15, 2024 11:33
Copy link
Contributor

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! everything looks good and all tests passed

Copy link
Contributor

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great! All tests past.

on a side note: I wonder if it would be a good idea to update the PR template testing section to include a comment that remind reviewers to install new packages if the branch includes new packages.

@Ajen07
Copy link
Contributor Author

Ajen07 commented Jun 16, 2024

Looks Great! All tests past.

on a side note: I wonder if it would be a good idea to update the PR template testing section to include a comment that remind reviewers to install new packages if the branch includes new packages.

Great suggestion , we can definitely do that.

@Ajen07 Ajen07 merged commit 07cfa31 into dev Jun 16, 2024
1 check passed
@Ajen07 Ajen07 deleted the test/e2e-tests-for-users branch June 16, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants