Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/teams unit tests #189

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Tests/teams unit tests #189

merged 6 commits into from
Aug 29, 2024

Conversation

JoshuaHinman
Copy link
Contributor

Description

Unit tests for teams controller and services

Issue link

Fixes # 86azu6kwr

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

yarn test:unit

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

Copy link
Contributor

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, all new and existing tests passed, I suggest updating toHaveBeenCalled to toHaveBeenCalledWith() in a couple of places

src/teams/teams.controller.spec.ts Show resolved Hide resolved
src/teams/teams.controller.spec.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. re-run the tests with the new changes, all passed

Copy link
Contributor

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! All unit tests passed!

@JoshuaHinman JoshuaHinman merged commit 190585f into dev Aug 29, 2024
1 check passed
@JoshuaHinman JoshuaHinman deleted the tests/teams-unit-tests branch August 29, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants