Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise question forms - Alpha Bug Fix [214, 217] #192

Merged
merged 2 commits into from
Aug 31, 2024
Merged

Conversation

JoshuaHinman
Copy link
Contributor

@JoshuaHinman JoshuaHinman commented Aug 30, 2024

Description

This PR revises two check in questions:
What is your role on the team? - removed
anyone deserves a shout out? - changed to input type teamMemberCheckBox

-waiting for new changelog file

Issue link

Fixes # 86b1yhjy1

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

yarn seed, verified in Prisma Studio

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

Copy link
Contributor

@curtwl curtwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JoshuaHinman JoshuaHinman merged commit e90d92c into dev Aug 31, 2024
1 check passed
@JoshuaHinman JoshuaHinman deleted the fix/ui-forms branch August 31, 2024 21:03
@cherylli cherylli changed the title Revise question forms Revise question forms - Alpha Bug Fix [214, 217] Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants