Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update check-in form SM and PO and change voyage-role[216] #196

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

Ajen07
Copy link
Contributor

@Ajen07 Ajen07 commented Sep 5, 2024

Description

  • Updated the question order in SM and PO check-in form
  • For PO it starts from 101 and for SM it starts from 201
  • Changed the voyage-role of one of the member from team 6 to PO

Issue link

Fixes # (issue)
chingu-x/chingu-dashboard#216

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • tested with yarn test:docker
  • tested with yarn seed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@Ajen07 Ajen07 self-assigned this Sep 5, 2024
@Ajen07 Ajen07 requested a review from cherylli September 5, 2024 13:15
@cherylli cherylli requested a review from curtwl September 5, 2024 23:27
Copy link
Contributor

@curtwl curtwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Could you also please update the prod database with these changes? Since we won't be re-seeding the data

@Ajen07 Ajen07 merged commit 6fdefb5 into dev Sep 6, 2024
1 check passed
@Ajen07 Ajen07 deleted the chore/seed-update-checkin-form-voyagerole branch September 6, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants