Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github workflow for PR reminder #202

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Add github workflow for PR reminder #202

merged 5 commits into from
Oct 4, 2024

Conversation

cherylli
Copy link
Contributor

Description

Add github workflow for PR reminder

Issue link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • [] My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@cherylli cherylli changed the title Create pr-reviwer-reminder.yml Add github workflow for PR reminder Sep 19, 2024
@curtwl
Copy link
Contributor

curtwl commented Sep 20, 2024

Cron syntax looks good, ran the script locally with Act with no errors.

@timDeHof
Copy link
Contributor

@curtwl I would like to test it with Act too. But I'm getting an error saying "Error: Parameter token or opts.auth is required". I looked and saw it asking for a GITHUB_TOKEN secret. Did you have this too? If so, where did you find it?

Copy link
Contributor

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't get this action to do anything when used it in another repo. But the cron expression is correct. I'm just not sure how to get it to work.

@cherylli
Copy link
Contributor Author

cherylli commented Sep 22, 2024

I added the same workflow to my fork and invited you two as an outside collaborator so I can request reviews.

then it should notify the reviewers 2 times a day if it works

@cherylli cherylli added the low priority label Sep 23, 2024
@timDeHof
Copy link
Contributor

timDeHof commented Oct 1, 2024

I didn't get any notifications yesterday. anybody else?

Copy link
Contributor

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just now got pinged in @cherylli's fork awhile. So it worked

Copy link
Contributor

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just now got pinged in @cherylli's fork awhile. So it worked

@cherylli cherylli merged commit 8d93d07 into dev Oct 4, 2024
1 check passed
@cherylli cherylli deleted the cherylli-patch-2 branch October 4, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants