Teams can create own tech categories

[JoshuaHinman]

Description

This PR completes the first part of task 86b1ym631
adds 3 routes for team tech stack categories (create, update, delete)
These are located in the techs section of the API
Now, each team will have it's own instances of the 6 main categories, and can also create their own
The schema for tech stack categories has been updated, along with seed data

Issue link

Fixes # 86b1ym631

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature updates / changes
• Tests
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Migrate for DB updates and seed:
npx prisma migrate dev

Test routes in swagger
Verify in DB: 66 categories for 11 teams
Verify duplicate category names for the same teamId throw an exception, and are case-insensitive - i.e. "TEST" === "Test"

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have updated the change log

[cherylli]

haven't looked at the code yet but saw this in the lint and test workflow, we need to make it nullable or set a default value. At this stage of the project I don't think it matters what we do since prod will be wiped after the alpha test or before the next test phase. Probably better to set a default value because we don't want it null.

But we need to remove the default value after the new schema is pushed/deployed to all databases.

thoughts?

[JoshuaHinman]

I changed the voyageTeamId relation to optional, even though I don't think it should be. It passed the check - It looks like the other relations are done this way too.

[cherylli]

I changed the voyageTeamId relation to optional, even though I don't think it should be. It passed the check - It looks like the other relations are done this way too.

sounds good. I think some of the relations are nullable because I needed to do that to set up "onDelete" referential actions on team deletion, when I don't want to cascade delete, there are probably better ways we can look into that later. It will probably be a lot more relavent when we are working on the admin dashboard

[cherylli]

removed @Ajen07 as a reviewer as he'll be away for 2 weeks

[cherylli]

is teamId same as voyageTeamId?

I tested on swagger (POST, PATCH, DELETE) they all work fine, ran all tests, still pass. Left a few comments but it's a good starting point for the change.

[JoshuaHinman]

is teamId same as voyageTeamId?

Yes that's right - I actually tried removing this param from the controller, but the response sent an error that said "URL shouldn't be empty". I couldn't find the source of the message. Should I remove voyageTeamId from the body?

[timDeHof]

All unit and e2e tests passed. db shows 66 categories for 11 teams. Also the POST techCategory endpoint throw an exception and is case-sensitive for duplicate category names on the same team id.

[cherylli]

Thanks! This is good. I have tested on swagger everything listed in the description works, I just have some questions and very minor changes requested

I assume tests would be added/updated in later parts? Maybe new tests for categories, and update old tests if needed

[cherylli]

Just randomly discovered this bug, but I think this may not be in the scope of this PR?

voyageTeam 1 doesn't own category 51, and I logged in as dan who is in voyageTeam1 but not in the team which owns category 51 (team 9)

====

Other things i've manually tested and all worked

• create a new tech stack category, throw 409 when duplicated (non case sensitive) as expected
• added the same category to different teams
• try to add category to someone elses team (403)
• patch (own team and other teams)
• delete (own team and other teams)

[JoshuaHinman]

voyageTeam 1 doesn't own category 51, and I logged in as dan who is in voyageTeam1 but not in the team which owns category 51 (team 9)

I don't think it's specific to this PR but it could be related.
I've seen similar issues before , I think it was because the user was an admin. It looks like Dan is an admin - is that causing the problem?

[cherylli]

voyageTeam 1 doesn't own category 51, and I logged in as dan who is in voyageTeam1 but not in the team which owns category 51 (team 9)

I don't think it's specific to this PR but it could be related. I've seen similar issues before , I think it was because the user was an admin. It looks like Dan is an admin - is that causing the problem?

In my database dan is not an admin, his only role is "voyager" but yeah if you want to fix this in another parts its fine, it's not a huge issue which stops the app from working.

[cherylli]

hi @timDeHof are you able to re- review this PR please

[timDeHof]

All tests passed! migrating db works. Also the preventing the duplicate tech category name works.