-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update regex in origin list #211
Conversation
Not sure how you want the changelog updated, if you do. Just let me know if you want me to do that and how |
You can just copy this format - https://github.com/chingu-x/chingu-dashboard-be/pull/205/files |
I pushed the changelog update |
@Dan-Y-Ko you reformatted the whole file 😂 |
🤔 All I did was copy the line and put it the change |
let me know if that fixed it |
Your IDE probably auto formatted it, I think it just added blank lines and removed extra spaces. I've also moved the change to the bottom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
The regex for the preview deployments is wrong. Vercel generates dynamic preview urls that can have - in them, which isn't covered in the regex.
For example: chingu-dashboard-git-feature-refreshtoken-chingu-dashboard.vercel.app
the feature-refreshtoken part is dynamic with a - in between
As a result, there's a cors error when testing from the preview deployments on vercel
Issue link
Fixes # (issue)
Type of change
How Has This Been Tested?
Tested through vercel
Checklist: