Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update regex in origin list #211

Merged
merged 4 commits into from
Oct 7, 2024
Merged

update regex in origin list #211

merged 4 commits into from
Oct 7, 2024

Conversation

Dan-Y-Ko
Copy link
Contributor

@Dan-Y-Ko Dan-Y-Ko commented Oct 2, 2024

Description

The regex for the preview deployments is wrong. Vercel generates dynamic preview urls that can have - in them, which isn't covered in the regex.

For example: chingu-dashboard-git-feature-refreshtoken-chingu-dashboard.vercel.app

the feature-refreshtoken part is dynamic with a - in between

As a result, there's a cors error when testing from the preview deployments on vercel

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested through vercel

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@Dan-Y-Ko
Copy link
Contributor Author

Dan-Y-Ko commented Oct 2, 2024

Not sure how you want the changelog updated, if you do. Just let me know if you want me to do that and how

@cherylli
Copy link
Contributor

cherylli commented Oct 2, 2024

You can just copy this format - https://github.com/chingu-x/chingu-dashboard-be/pull/205/files

@Dan-Y-Ko
Copy link
Contributor Author

Dan-Y-Ko commented Oct 2, 2024

You can just copy this format - https://github.com/chingu-x/chingu-dashboard-be/pull/205/files

I pushed the changelog update

@cherylli
Copy link
Contributor

cherylli commented Oct 3, 2024

@Dan-Y-Ko you reformatted the whole file 😂
image

@Dan-Y-Ko
Copy link
Contributor Author

Dan-Y-Ko commented Oct 3, 2024

@Dan-Y-Ko you reformatted the whole file 😂 image

🤔 All I did was copy the line and put it the change

@Dan-Y-Ko
Copy link
Contributor Author

Dan-Y-Ko commented Oct 3, 2024

let me know if that fixed it

@cherylli
Copy link
Contributor

cherylli commented Oct 4, 2024

@Dan-Y-Ko you reformatted the whole file 😂 image

🤔 All I did was copy the line and put it the change

Your IDE probably auto formatted it, I think it just added blank lines and removed extra spaces. I've also moved the change to the bottom

@cherylli cherylli requested a review from curtwl October 4, 2024 05:20
Copy link
Contributor

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor

@curtwl curtwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cherylli cherylli merged commit fe11a09 into dev Oct 7, 2024
1 check passed
@cherylli cherylli deleted the fix/origin-regex branch October 7, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants