Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add same site property to logout method and update cors origin list #218

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

Dan-Y-Ko
Copy link
Contributor

@Dan-Y-Ko Dan-Y-Ko commented Oct 22, 2024

Description

Added same site to the logout method (where cookies are cleared).

Also ran into an issue with cors again. I updated the list to account for numbers and underscores.

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I tested with localhost on the backend and in vercel preview deployment

https://chingu-dashboard-git-refactor-auth-arch-a87d55-chingu-dashboard.vercel.app/dashboard

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

Dan-Y-Ko and others added 3 commits October 21, 2024 22:12
… logout method and consolidating cookie options

chore(auth): remove unused MailConfigService import to clean up code and improve maintainability
@cherylli cherylli self-requested a review October 22, 2024 03:05
@curtwl curtwl self-requested a review October 22, 2024 03:17
Copy link
Contributor

@curtwl curtwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed

Copy link
Contributor

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactored and tested

@Dan-Y-Ko Dan-Y-Ko merged commit fa3734f into dev Oct 22, 2024
1 check passed
@Dan-Y-Ko Dan-Y-Ko deleted the fix/logout-same-site branch October 22, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants