Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/refactor-email-service #232

Merged
merged 6 commits into from
Dec 22, 2024
Merged

Feat/refactor-email-service #232

merged 6 commits into from
Dec 22, 2024

Conversation

andram11
Copy link
Contributor

Description

refactor of the email service in order to:

  • create one single sendEmail function which uses variables for each type of template
  • not run in test mode
  • added unit tests for email service

Issue link

Fixes # (https://app.clickup.com/t/86b2343x3)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests were created

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@andram11 andram11 marked this pull request as ready for review December 17, 2024 20:07
Copy link

@timDeHof, @cherylli
One business day has passed since the review started. Give priority to reviews as much as possible.

@cherylli
Copy link
Contributor

@andram11 could you please resolve merge conflicts when you have a chance? Thanks!

Copy link
Contributor

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! All the tests passed! I added some suggestions to improve the tests of the email service that could help improve the overall test organization and reduce code duplication.

CHANGELOG.md Outdated Show resolved Hide resolved
src/utils/emails/email.service.spec.ts Show resolved Hide resolved
src/utils/emails/email.service.spec.ts Show resolved Hide resolved
src/utils/emails/email.service.spec.ts Show resolved Hide resolved
src/utils/emails/email.service.spec.ts Outdated Show resolved Hide resolved
src/utils/emails/email.service.spec.ts Outdated Show resolved Hide resolved
src/utils/emails/email.service.spec.ts Outdated Show resolved Hide resolved
src/utils/emails/email.service.spec.ts Outdated Show resolved Hide resolved
src/utils/emails/email.service.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

Copy link
Contributor

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, exactly what I wanted. Looked at the code and ran all tests ✅

@andram11 andram11 merged commit 775d0dd into dev Dec 22, 2024
1 check passed
@andram11 andram11 deleted the feat/refactor-email-service branch December 22, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants