-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/refactor-email-service #232
Conversation
@andram11 could you please resolve merge conflicts when you have a chance? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! All the tests passed! I added some suggestions to improve the tests of the email service that could help improve the overall test organization and reduce code duplication.
…efactoring suggested by Tim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, exactly what I wanted. Looked at the code and ran all tests ✅
Description
refactor of the email service in order to:
Issue link
Fixes # (https://app.clickup.com/t/86b2343x3)
Type of change
How Has This Been Tested?
Unit tests were created
Checklist: