Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update antlr submodule. #3088

Merged

Conversation

hzeller
Copy link
Collaborator

@hzeller hzeller commented Jul 6, 2022

Fixes #3081

Signed-off-by: Henner Zeller h.zeller@acm.org

@alaindargelas
Copy link
Collaborator

More Windows breakage in Antlr:
FAILED: third_party/antlr4/runtime/Cpp/runtime/CMakeFiles/antlr4_static.dir/src/CharStream.cpp.obj
C:\PROGRA1\MICROS2\2022\ENTERP1\VC\Tools\MSVC\14321.313\bin\Hostx64\x64\cl.exe /nologo /TP -DANTLR4CPP_STATIC -ID:\a\Surelog\Surelog\third_party\antlr4\runtime\Cpp\runtime\src -ID:\a\Surelog\Surelog\third_party\antlr4\runtime\Cpp\runtime\src\atn -ID:\a\Surelog\Surelog\third_party\antlr4\runtime\Cpp\runtime\src\dfa -ID:\a\Surelog\Surelog\third_party\antlr4\runtime\Cpp\runtime\src\internal -ID:\a\Surelog\Surelog\third_party\antlr4\runtime\Cpp\runtime\src\misc -ID:\a\Surelog\Surelog\third_party\antlr4\runtime\Cpp\runtime\src\support -ID:\a\Surelog\Surelog\third_party\antlr4\runtime\Cpp\runtime\src\tree -ID:\a\Surelog\Surelog\third_party\antlr4\runtime\Cpp\runtime\src\tree\pattern -ID:\a\Surelog\Surelog\third_party\antlr4\runtime\Cpp\runtime\src\tree\xpath /DWIN32 /D_WINDOWS /GR /EHsc -Wall -pedantic -W /O2 /Ob2 /DNDEBUG -O3 -DNDEBUG -MT /wd4251 -std:c++17 /showIncludes /Fothird_party\antlr4\runtime\Cpp\runtime\CMakeFiles\antlr4_static.dir\src\CharStream.cpp.obj /Fdthird_party\antlr4\runtime\Cpp\runtime\antlr4-runtime-static.pdb /FS -c D:\a\Surelog\Surelog\third_party\antlr4\runtime\Cpp\runtime\src\CharStream.cpp
cl : Command line error D8004 : '/W' requires an argument
ninja: build stopped: subcommand failed.
make: *** [Makefile:22: release] Error 1
Error: Process completed with exit code 2.

@hs-apotell
Copy link
Collaborator

Changes were introduced between the time I created the PR and the same got accepted and merged. Incidentally, there is no CI verification build for Windows + MSVC for antlr and so none of these issues get caught when they should be. There were number of issues in the Cpp runtime's CMakeFile.txt. Here's the PR to fix these issues - antlr/antlr4#3777

Fixes chipsalliance#3081

Signed-off-by: Henner Zeller <h.zeller@acm.org>
@hzeller hzeller force-pushed the 20220706-update-antlr-module branch from 5e51052 to d8e7719 Compare July 6, 2022 21:12
@hzeller
Copy link
Collaborator Author

hzeller commented Jul 6, 2022

@hs-apotell 's PR has been accepted, I've now updated the submodule again, let's see what happens.

@hzeller
Copy link
Collaborator Author

hzeller commented Jul 6, 2022

The remaining issue in the CI has something to do with CoresSweRVMP.log which was broken before.

@alaindargelas alaindargelas merged commit 4ff90c0 into chipsalliance:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest Antlr broken on Clang
3 participants