sw-emulator: Add dilithium peripheral #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korran
reviewed
Jul 30, 2024
jhand2
reviewed
Jul 30, 2024
ArthurHeymans
force-pushed
the
dilithium_sw_emu
branch
from
599e8a7 to
7987f44
Compare
jhand2
reviewed
Aug 20, 2024
swenson
reviewed
Aug 20, 2024
ArthurHeymans
force-pushed
the
dilithium_sw_emu
branch
from
7987f44 to
1df2680
Compare
mhatrevi
approved these changes
Aug 26, 2024
Rust only implements Default for arrays up to 64 elements. The dilithium keys and signature are larger so implement the default for U32ArrayBytes explicitly. Signed-off-by: Arthur Heymans <arthur.heymans@9elements.com>
This adds a peripheral capable of PQC using the fips204 ML_DSA_87 algorithm. To implement this peripheral the crystals-dilithium crate https://crates.io/crates/fips204 A few TODOs are left in the code: - The exact keygen algoritm has not be disclosed - Version and name field need to be updated to match the HW - The MMIO base needs to be updated to match the HW Signed-off-by: Arthur Heymans <arthur.heymans@9elements.com>
ArthurHeymans
force-pushed
the
dilithium_sw_emu
branch
from
1df2680 to
f5fbb02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the dilithium peripheral in the sw-emulator based on preliminary support available.
Things currently unknown like how certain functionality works exactly and the MMIO offset are marked as TODO so that those can be updated once more details are available.