Add alignment check to PersistentData structure. #1774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clundin25
requested review from
mhatrevi,
ajisaxena,
vsonims,
korran,
JohnTraverAmd,
rusty1968 and
swenson
as code owners
clundin25
force-pushed
the
persistent-data-alignment
branch
from
cc66872 to
f4febe4
Compare
jhand2
approved these changes
Nov 5, 2024
|
Closing this in favor of #1722, which includes this check (amongst other changes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should also check that the address after the
PersistentDatastruct isDATA_ORG. Currently we are mostly checking that the struct sizes add up.