Tweak UART messages to buy some RO memory in ROM. #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clundin25
requested review from
mhatrevi,
ajisaxena,
vsonims,
korran,
JohnTraverAmd and
swenson
as code owners
clundin25
force-pushed
the
compress-uart-messages
branch
from
52f9aca to
bb5b14e
Compare
jhand2
previously approved these changes
Nov 6, 2024
clundin25
force-pushed
the
compress-uart-messages
branch
from
bb5b14e to
cfde497
Compare
jhand2
previously approved these changes
Nov 6, 2024
clundin25
force-pushed
the
compress-uart-messages
branch
from
25e5a1f to
188c02d
Compare
jhand2
reviewed
Nov 7, 2024
This reverts commit 188c02d.
mhatrevi
approved these changes
Nov 7, 2024
jhand2
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1732 pushes the code size too far. Re-coup some of the code-size for the UART image by compressing some of the existing messages.