Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing release CI failures and adding frozen 1.1 ROM #1809

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Fixing release CI failures and adding frozen 1.1 ROM #1809

merged 3 commits into from
Nov 25, 2024

Conversation

nquarton
Copy link
Contributor

No description provided.

@nquarton nquarton marked this pull request as ready for review November 21, 2024 01:04
@nquarton nquarton requested a review from korran November 21, 2024 01:05
korran
korran reviewed Nov 21, 2024
View reviewed changes
runtime/Cargo.toml Outdated Show resolved Hide resolved
@nquarton nquarton force-pushed the nquarton/fix_nightly_add_1_1_ci_rom branch 4 times, most recently from 2727939 to b278314 Compare November 22, 2024 04:20
@nquarton nquarton force-pushed the nquarton/fix_nightly_add_1_1_ci_rom branch from b278314 to 5f87e7f Compare November 22, 2024 16:52
@nquarton
Removing reference to main branch in release flow
8d82d6a 
Prevents a release being made from main when tests were actuall run
on a different branch/commit
@nquarton
Copy link
Contributor Author

This run shows it solving all the test failures in the nightly. (The final publish step fails as expected since this is not the main branch).
https://github.com/chipsalliance/caliptra-sw/actions/runs/11976900101

@JohnTraverAmd JohnTraverAmd merged commit 5daf1b4 into main Nov 25, 2024
11 checks passed
@nquarton nquarton linked an issue Nov 25, 2024 that may be closed by this pull request
Add testing against frozen 1.1 ROM to CI to support 1.2 ROM and FW releases #1762
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korran korran korran left review comments

@jlmahowa-amd jlmahowa-amd jlmahowa-amd approved these changes

@mhatrevi mhatrevi mhatrevi approved these changes

@jhand2 jhand2 jhand2 approved these changes

@fdamato fdamato Awaiting requested review from fdamato fdamato is a code owner

@rusty1968 rusty1968 Awaiting requested review from rusty1968 rusty1968 is a code owner

@bluegate010 bluegate010 Awaiting requested review from bluegate010 bluegate010 is a code owner

@swenson swenson Awaiting requested review from swenson swenson is a code owner

@vsonims vsonims Awaiting requested review from vsonims vsonims is a code owner

@FerralCoder FerralCoder Awaiting requested review from FerralCoder FerralCoder is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add testing against frozen 1.1 ROM to CI to support 1.2 ROM and FW releases
6 participants
@nquarton @korran @jhand2 @mhatrevi @jlmahowa-amd @JohnTraverAmd