Skip to content

Commit

Permalink
Fix issue where reify would do the same lookup twice (#3392) (#3397)
Browse files Browse the repository at this point in the history
This is not a functional bug. The recursive form of reify for Element
would use the .topBinding from the wrong argument, so it would recurse
an extra time, but it would ultimately converge to the right value.

(cherry picked from commit 374b45b)

Co-authored-by: Jack Koenig <koenig@sifive.com>
  • Loading branch information
mergify[bot] and jackkoenig authored Jun 29, 2023
1 parent 44c3fab commit 7e64a04
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ package object dataview {
*/
@tailrec private[chisel3] def reify(elt: Element, topBinding: TopBinding): Element =
topBinding match {
case ViewBinding(target) => reify(target, elt.topBinding)
case ViewBinding(target) => reify(target, target.topBinding)
case _ => elt
}

Expand Down

0 comments on commit 7e64a04

Please sign in to comment.