Private vals don't get named by reflection nor @chiselName

[jackkoenig]

The most egregious example is in Queue which uses private vals. Now perhaps we should just make them public, but the issue still stands.

Long ago, Chisel reflective naming worked on private val (#407), it seems this is no longer true.

It's also of note that @chiselName doesn't name private vals.

I feel like both of these are bugs that should be fixed.

Type of issue: bug report

Impact: API addition (no impact on existing code)

Development Phase: request

[mwachs5]

There was a workaround for some other issue that was maybe relying on this behavior: #1352

[seldridge]

(Having not tested it and just looking through issues/PRs...) How does the Chisel naming plugin handle this? Does that close this issue?

[jackkoenig]

Just checked, the plugin does indeed handle this!

Fixed by #1448