Private vals #407
Merged
Private vals #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chick
reviewed
Dec 14, 2016
| * without $$ unchanged | ||
| */ | ||
| def cleanName(name: String): String = { | ||
| val split = name.split("\\$\\$") |
There was a problem hiding this comment.
Could be single lined as
name.split("""\$\$""").lastOption.getOrElse(name)
jackkoenig
force-pushed
the
private-vals
branch
from
f3e55a0
to
4ea3014
Compare
jackkoenig
force-pushed
the
private-vals
branch
from
4ea3014
to
286696c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After looking at the public API for Queue (see all of the public vals https://chisel.eecs.berkeley.edu/api/index.html#chisel3.util.Queue), I wanted to clean it up a little bit.
So it turns out that Chisel already names private vals, Scala just gives them really crazy names (like chisel3$util$Queue$$ram) so I wrote a function to clean these names up. I have not been able to figure out a way to detect if something is a private val via java reflection so this cleanup is my hacky alternative. Suggestions welcome.
I also changed all of the public fields in util that I could find that have no business being public (since accessing them externally would result in invalid Firrtl)