Mill support for Chisel3 #1035
Merged
Mill support for Chisel3 #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still some problems building source and doc jars, largely due to relative paths.
- need to specify mainClass - mill should figure it out on its own - manifest isn't complete - javaDoc is missing version info, some javascript, and differs from sbt generated javaDoc, but it doesn include core and internal documentation - ivys are missing description, configurations, scala dependencies - poms use artifactId for name (instead of descrption), license is BSD-3-Clause, developer is missing url, dependencies are missing scala dependencies, but include a dependency on the library itself(!).
Move common code into CommonBuild.sc Remove extra ThisBuildInfo trait Override publishXmlDeps() to avoid generating a self-dependency (since our dependent modules don't really have their own identity and end up duplicating PublishChiselModule
edwardcwang
added
the
Squash and merge
ucbjrl
reviewed
Mar 19, 2019
There was a problem hiding this comment.
Looks pretty good @edwardcwang. I'm getting test failures with the make mill.test.all target. I'm trying to sort that out.
ucbjrl
approved these changes
Mar 19, 2019
|
@ucbjrl Thank you so much for looking into this! Let me test this out and I'll get back to you. |
|
This appears to work; will go ahead and squash-merge this. |
Merged
jackkoenig
pushed a commit
that referenced
this pull request
Feb 28, 2023
…ng. (#1035) * Add --nodedup option to facilitate FIRRTL to verilog regression testing. * Short-circuit the DedupModules transform if NoCircuitDedupAnnotation exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change: feature
Impact: no functional change
Development Phase: implementation
Release Notes: Support mill in Chisel3.