Fixup and enable Dummy CompatibilitySpec test #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
seldridge
force-pushed
the
enable-dummy-compatibility-test
branch
from
1cdfd3c
to
0997652
Compare
jackkoenig
pushed a commit
that referenced
this pull request
Feb 28, 2023
…1142) - Provide new tools for reading in text - from a file - from a string file name - from a resource file - text can be read in as - a single string with newlines - a seq of strings, one string per line - FileUtils put in its own file - in same package to keep existing API the same Hopefully this will protect users from creating resource leaks that may explain sbt crashing. Also simpler interface should make code more streamlined, existing uses of io.Source seem often to be converting between text and seq unnecessarily. Add note of caution on requiring slash on resource readers
jackkoenig
pushed a commit
that referenced
this pull request
Feb 28, 2023
Fixes a threading bug in where lazy reading of file caused a problem for multithreaded access to the that was read. Changes all uses of io.Source to use new API getText getLines getTextResource getLinesResouce Make style to only import FileUtils and not its methods So code is more explicit as e.g. FileUtils.getText()
jackkoenig
pushed a commit
that referenced
this pull request
Feb 28, 2023
- use scala.io.Source instead of io.Source - .toList cleaner way to force stream to be read. - clear old commented out code in ProtoBufSpec
jackkoenig
pushed a commit
that referenced
this pull request
Feb 28, 2023
…-fileutils Followup to PR #1142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checks in the
Dummymodule inside theCompatibilitySpecwere never actually running. This fixes these up to work and runs the test.Related issue:
Type of change: bug report | other enhancement
Impact: no functional change
Development Phase: implementation